Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add eslint role for no message description #460

Closed
wants to merge 1 commit into from
Closed

feat: add eslint role for no message description #460

wants to merge 1 commit into from

Conversation

ghassanmas
Copy link
Member

This uses an eslint role for getting strings with no
descriptions, this for demonstration purpose and can be used
for checking other MFEs or JS/React base repos

Ref: openedx/wg-translations/issues/5
Related discussion: openedx/frontend-app-learning/pull/1143

@ghassanmas
feat: add eslint role for no message description
0a32690 
  This uses an eslint role for getting strings with no
  descriptions, this for demonstration purpose and can be used
  for checking other MFEs or JS/React base repos

  Ref: openedx/wg-translations/issues/5
  Related discussion: openedx/frontend-app-learning/pull/1143
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 27, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 27, 2023 •
edited
Loading

Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@itsjeyd
Copy link

itsjeyd commented Oct 10, 2023

@ghassanmas Thanks for these changes! Aside from resolving some merge conflicts, it looks like they're ready for review?

@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Oct 10, 2023
@itsjeyd
Copy link

itsjeyd commented Nov 8, 2023

Hey @ghassanmas, just checking in to see if you're still planning to come back to this PR?

@itsjeyd
Copy link

itsjeyd commented Nov 23, 2023

Hi @ghassanmas! Just a quick update that we're closing this PR now because it seems to have become stale. You may reopen this pull request, or open a new one, when you have time to come back to this work.

@itsjeyd itsjeyd closed this Nov 23, 2023
@openedx-webhooks
Copy link

@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added closed inactivity PR was closed because the author abandoned it and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Nov 23, 2023
@ghassanmas
Copy link
Member Author

@itsjeyd I would be happy to continue wokring on resolving the conflicts, if there would a guarantee that this changes/ PR would be accepted at somepoint. This is just to avoid spending time on someting that might not be accepted. I think following openedx/frontend-app-learning#1143, @brian-smith-tcril might have a say on that.

@ehuthmacher ehuthmacher reopened this Feb 16, 2024
@ehuthmacher ehuthmacher mentioned this pull request Feb 16, 2024
Open
@itsjeyd itsjeyd removed the closed inactivity PR was closed because the author abandoned it label Feb 23, 2024
@itsjeyd
Copy link

itsjeyd commented Mar 11, 2024

OSPR management note: See openedx/wg-translations#5 (comment) for latest status. (This PR is still blocked waiting for general confirmation about whether it has a chance of being accepted at some point.)

CC @ehuthmacher

@brian-smith-tcril
Copy link
Contributor

I discussed this with the Axim team and we decided a change like this will need to include a plan for all the consumers of frontend-build to support the new eslint rule. I have opened a PR #516 creating an alternate eslint config (eslint-next) that can be pulled in to MFEs using createConfig('eslint-next', { (example here openedx/frontend-app-learning#1319)

This will allow us to migrate applications that depend on frontend-build over (and add descriptions to the source strings) without breaking their ability to upgrade frontend-build.

I've created an issue laying out the high level plan #517

@ghassanmas ghassanmas closed this Mar 20, 2024
@itsjeyd itsjeyd added the duplicate This issue or pull request already exists elsewhere label Mar 22, 2024
@brian-smith-tcril brian-smith-tcril mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). duplicate This issue or pull request already exists elsewhere open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ghassanmas @openedx-webhooks @itsjeyd @brian-smith-tcril @ehuthmacher